[PATCH v4 2/8] test-lib-functions: test_cmp: eval $GIT_TEST_CMP

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Mar 26, 2020, 04:37 UTC
Message-ID: <31d4a9b2e8f29b8477be5a53890d86b28fe13f8a.1585197360.git.congdanhqx@gmail.com>
In-Reply-To: <cover.1585197360.git.congdanhqx@gmail.com>

Shell recognises first non-assignment token as command name. With /bin/sh linked to either /bin/bash or /bin/dash, `cd t/perf && ./p0000-perf-lib-sanity.sh -d -i -v` reports:

> test_cmp:1: command not found: diff -u

Using `eval` to unquote $GIT_TEST_CMP as same as precedence in `git_editor`.

Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
---
 t/test-lib-functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 352c213d52..ab0e47ae17 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -905,7 +905,7 @@ test_expect_code () {
 # - not all diff versions understand "-u"
 
 test_cmp() {
-	$GIT_TEST_CMP "$@"
+	eval "$GIT_TEST_CMP" '"$@"'
 }
 
 # Check that the given config key has the expected value.

-- 
2.26.0.rc2.357.g1e1ba0441d