Re: [PATCH v2 7/8] t4124: fix test for non-compliant diff(1)
- From
Danh Doan <congdanhqx@gmail.com>
- Date
- Mar 25, 2020, 14:24 UTC
- Message-ID
- <20200325142421.GA20898@danh.dev>
- In-Reply-To
- <xmqqy2rp1tff.fsf@gitster.c.googlers.com>
On 2020-03-24 11:47:32-0700, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Danh Doan <congdanhqx@gmail.com> writes: > > > Hence, if we're going to drop support for system that doesn't > > understand "diff -u", we're going to: > > - remove support for those variables: > > + GIT_TEST_CMP_USE_COPIED_CONTEXT > > Folks who prefer "-c" even their platforms all are capable of "-u" > may miss this, but I think that is a very small minority, and they > would be OK (it is after all only needed when diagnosing test > failures of our test suite, and by definition, those who are working > to improve Git would know how to read "-u" output). > > > + GIT_TEST_CMP > > I am not sure why you need to drop this one? This is more about > switching between "diff" and "cmp", and there are reasons why folks > prefer latter especially when they are not debugging the tests.
I was thinking it could simplify the test_cmp code. There was a problem which needs to be addressed by 2/8.
Yes, people may prefer to use cmp(1) because cmp(1) should be faster than diff(1).
Anyway, it seems like we've decided to keep using normal-diff because of HP-UX.
-- Danh