Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 2, 2019, 19:57 UTC
Message-ID: <nycvar.QRO.7.76.6.1903022056500.45@tvgsbejvaqbjf.bet>
In-Reply-To: <20190301215414.GB1518@sigill.intra.peff.net>

Hi Peff,

On Fri, 1 Mar 2019, Jeff King wrote:

Show 14 quoted lines

> On Fri, Mar 01, 2019 at 04:36:19PM -0500, Jeff King wrote:
> 
> > > This has one notable consequence: we no longer include
> > > `command-list.h` in `LIB_H`, as it is a generated file, not a
> > > tracked one.
> > 
> > We should be able to add back $(GENERATED_H) as appropriate. I see you
> > did it for the non-computed-dependencies case. Couldn't we do the same
> > for $(LOCALIZED_C) and $(CHK_HDRS)?
> 
> Answering my own question somewhat: $(CHK_HDRS) explicitly ignores the
> generated headers, so we wouldn't want to bother re-adding it there
> anyway. Possibly $(LOCALIZED_C) would care, though. The generated file
> does have translatable strings in it.

Yes, and it is defined thusly:

	LOCALIZED_C = $(C_OBJ:o=c) $(LIB_H) $(GENERATED_H)

So it does include the generated headers explictly anyway, with or without my patch.

Ciao, Dscho