Re: [PATCH v2 1/1] Makefile: use `git ls-files` to list header files, if possible
- From
Jeff King <peff@peff.net>
- Date
- Mar 4, 2019, 21:43 UTC
- Message-ID
- <20190304214346.GC3347@sigill.intra.peff.net>
- In-Reply-To
- <cb253bd0cf2896cf31516079a89ec2dab21032cf.1551707225.git.gitgitgadget@gmail.com>
On Mon, Mar 04, 2019 at 05:47:06AM -0800, Johannes Schindelin via GitGitGadget wrote:
Show 6 quoted lines
> Therefore, just like in 335339758c (Makefile: ask "ls-files" to list > source files if available, 2011-10-18), we now prefer to use `git > ls-files` to enumerate the header files to enumerating them via `find`, > falling back to the latter if the former failed (which would be the case > e.g. in a worktree that was extracted from a source .tar file rather > than from a clone of Git's sources).
Thanks, this version looks good to me, and seems like an obvious first step regardless of whether we want to later push it into a sub-make.
-Peff