Re: [PATCH 1/1] Makefile: use `git ls-files` to list header files, if possible

From: Jeff King <peff@peff.net>
Date: Mar 4, 2019, 21:41 UTC
Message-ID: <20190304214155.GB3347@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1903041206300.45@tvgsbejvaqbjf.bet>

On Mon, Mar 04, 2019 at 12:08:41PM +0100, Johannes Schindelin wrote:

Show 16 quoted lines

> -- snipsnap --
> From c13d9985284d4b452db0d95b6949e02c533db634 Mon Sep 17 00:00:00 2001
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
> Date: Sat, 23 Feb 2019 20:38:40 +0100
> Subject: [PATCH] hdr-check: make it work on Windows
> 
> On Windows, we define a specific set of pre-processor macros, among
> other reasons: to avoid including syslog.h (which is not available on
> Windows).
> 
> The hdr-check target did not use those definitions, resulting in a
> failure to include said syslog.h.
> 
> To fix that, let's let the hdr-check target make use of ALL_CFLAGS,
> which does include the pre-processor macros that would e.g. skip the
> conditional block including syslog.h.

This makes sense to me, though as you noted elsewhere, it doesn't fix the gcrypt problem, since that file unconditionally wants to look at the system gcrypt.h (and we control at the Makefile level whether we actually look at sha256/gcrypt.h).

-Peff