Re: [PATCH 1/1] Makefile: add prove and coverage-prove targets

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 31, 2019, 07:23 UTC
Message-ID: <nycvar.QRO.7.76.6.1901310819180.41@tvgsbejvaqbjf.bet>
In-Reply-To: <87womm2b7r.fsf@evledraar.gmail.com>

Hi Ævar,

On Wed, 30 Jan 2019, Ævar Arnfjörð Bjarmason wrote:

Show 19 quoted lines

> Let's get some numbers then. On master, go to the "t" directory and run
> this:
> 
>     for f in t[0-9]*.sh; do (echo '#!/bin/sh' && echo "echo ok 1 $f" && echo sleep 1 && echo echo 1..1) >$f; done
>
> That effectively turns all our tests into a "hello world" with a sleep
> of 1 second.
> 
> Then run both:
> 
>     time prove -j12 t00[0-9]*.sh
> 
> And:
> 
>     time make -j12 t00[0-9]*.sh
> 
> For some value of -j12 and t00[0-9]*.sh. In my testing "make" is a bit
> faster, but not by any amount that would matter when this is run for
> real.

Hmm. You're right, I basically see a range of 5.17-5.27 seconds, all well in the noise.

So apart from the size for Perl (which accounts for about a third of the subset of the Git for Windows SDK we have to download into each and every CI run, multiple times) it does not hurt that much at the moment, you're right.

Still, I would like to get away from our reliance on Perl in the test suite. It does not make sense to require Perl even with NO_PERL.

Ciao, Dscho