Re: [PATCH 1/1] Makefile: add prove and coverage-prove targets

From: Jeff King <peff@peff.net>
Date: Jan 29, 2019, 16:49 UTC
Message-ID: <20190129164947.GB6991@sigill.intra.peff.net>
In-Reply-To: <a5ca8985-f877-b250-d186-32bef40092f5@gmail.com>

On Tue, Jan 29, 2019 at 11:37:34AM -0500, Derrick Stolee wrote:

Show 8 quoted lines

> > I'm afraid that this issue would badly affect 'coverage-prove' as well
> > (I didn't try).  Or if doesn't (anymore?), then that should be
> > mentioned in the commit message, and then perhaps it's time to remove
> > that '-j1' from the 'coverage-test' target as well.
> 
> I'll fix this by forcing an update to GIT_PROVE_OPTS. It does limit our
> ability to use GIT_PROVE_OPTS as a pass-through, but at least this new
> target will have that assumption built in.

I think doing:

  make GIT_PROVE_OPTS="$(GIT_PROVE_OPTS) -j1"

should be sufficient to pass through most of the options but override -j, since prove does the usual left-to-right "last one wins" behavior for its options.

-Peff