Re: [PATCH 1/1] Makefile: add prove and coverage-prove targets

From: Jeff King <peff@peff.net>
Date: Jan 29, 2019, 22:38 UTC
Message-ID: <20190129223807.GC1895@sigill.intra.peff.net>
In-Reply-To: <87zhrj2n2l.fsf@evledraar.gmail.com>

On Tue, Jan 29, 2019 at 10:03:46PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 15 quoted lines

> > I think these are reasonable to have (and I personally much prefer
> > "prove" to the raw "make test" output anyway).
> 
> I wonder if anyone would mind if we removed the non-prove path.
> 
> When I added it in 5099b99d25 ("test-lib: Adjust output to be valid TAP
> format", 2010-06-24) there were still some commonly shipped OS's that
> had a crappy old "prove", but now almost a decade later that's not a
> practical problem, and it's installed by default with perl, and we
> already depend on perl for the tests.
> 
> I don't feel strongly about it, but it would allow us to prune some
> login in the test library / Makefile.
> 
> Maybe something for a show of hands at the contributor summit?

Certainly no argument from me personally, but I do wonder if anybody uses the old one. Maybe we could mark it with a deprecation notice or something. I'd be happy to do a straw poll at the contributor summit (or on the list, if anybody reads this ;) ).

-Peff