Re: [PATCH v2 1/3] git clone <url> C:\cygwin\home\USER\repo' is working (again)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 11, 2018, 13:39 UTC
Message-ID: <nycvar.QRO.7.76.6.1812111429320.43@tvgsbejvaqbjf.bet>
In-Reply-To: <CAAXzdLUKhCfvqdvsPryeMGJ2ttJxof4sUcyTx-xd5p2BaoryiQ@mail.gmail.com>

Hi Steven,

On Mon, 10 Dec 2018, Steven Penny wrote:

Show 5 quoted lines

> On Mon, Dec 10, 2018 at 2:46 AM Johannes Schindelin wrote:
> > please stop dropping me from the Cc: list. Thanks.
> 
> i dropped you specifically because i knew you were going to flame like
> you just did below. oh well, i guess you cant avoid the inevitable.

I have no intention of flaming anybody. That is simply a misrepresentation.

Show 7 quoted lines

> > > - pc-windows
> > > - pc-win
> > > - win
> >
> > I find all of those horrible.
> 
> they arent great, but "win32" simply isnt valid.

It is a long established convention to talk about the Win32 API as the set of functions developed for Windows NT and backported to Windows 95.

There is no benefit in abandoning that convention just to please you.

Show 10 quoted lines

> > ... except if you take into account that this has been our convention
> > for, what, almost 9 years (since 44626dc7d5 (MSVC: Windows-native
> > implementation for subset of Pthreads API, 2010-01-15), to be
> > precise)? In that case, it makes a ton of sense, and one might be
> > tempted to ask who the person wanting to change that thinks they
> > are...
> 
> "That's the way it's always been done" is not a good reason to keep
> doing something. I would say the justification goes the other way, as to
> why we should keep using an old moniker when its past making sense.

If you want to change something that has been in use for a long time, you have to have good reasons. None of your arguments convinces me so far that you have any good reason to change these.

Let's hear some good argument in a well-prepared patch, or alternatively let's just not discuss these hypotheticals anymore.

Show 7 quoted lines

> > You may disagree all you want, but given that Torsten has been a lot
> > more active on this code than you have been so far, I'll go with
> > Torsten's taste. Which incidentally happens to match my tastes, so
> > that's an added bonus.
> 
> in the end i dont really care what your taste is, or Torsten for that
> matter. I care that the issue be fixed.

If anyone truly cares about an issue to be fixed, I would expect more assisting, and less distracting, to do wonders.

Ciao, Johannes