Re: [PATCH v1/RFC 1/1] 'git clone <url> C:\cygwin\home\USER\repo' is working (again)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 27, 2018, 12:55 UTC
Message-ID: <nycvar.QRO.7.76.6.1811271352560.41@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqlg5ft7pe.fsf@gitster-ct.c.googlers.com>

Hi Junio,

On Tue, 27 Nov 2018, Junio C Hamano wrote:

Show 18 quoted lines

> Steven Penny <svnpenn@gmail.com> writes:
> 
> > If you strip the drive, you can still navigate within the same drive:
> >
> >     $ cd 'C:\Users'
> >     $ pwd
> >     /cygdrive/c/Users
> >
> >     $ cd '\Windows'
> >     $ pwd
> >     /cygdrive/c/Windows
> >
> > but you can no longer traverse drives:
> >
> >     $ cd '\Testing'
> >     sh: cd: \Testing: No such file or directory
> 
> Sorry, but I fail to see the point the last example wants to make.

I agree. For me, the real test is this:

me@work ~ $ cd /cygdrive

me@work /cygdrive $ ls c d

So `/cygdrive` *is* a valid directory in Cygwin.

Show 6 quoted lines

> > I would say these could be merged into a "win.h" or similar. Cygwin typically
> > leans toward the "/unix/style" while MINGW has been more tolerant of
> > "C:\Windows\Style" and "C:/Mixed/Style" paths, i dont see that changing.
> 
> I'd defer to Windows folks to decide if a unified win.h is a good
> idea.

We already have such a thing, but it is not just `win.h`, it is `compat/win32/`. I would think that the best idea would be to move the MINGW variants to `compat/win32/path-utils.c` and declare them in `compat/win32/path-utils.h`, renaming them from `mingw_*()` to `win32_*()`.

Ciao, Dscho