Re: [PATCH v2 1/3] git clone <url> C:\cygwin\home\USER\repo' is working (again)

From: Steven Penny <svnpenn@gmail.com>
Date: Dec 10, 2018, 12:45 UTC
Message-ID: <CAAXzdLUKhCfvqdvsPryeMGJ2ttJxof4sUcyTx-xd5p2BaoryiQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1812100938140.43@tvgsbejvaqbjf.bet>

On Mon, Dec 10, 2018 at 2:46 AM Johannes Schindelin wrote:

> please stop dropping me from the Cc: list. Thanks.

i dropped you specifically because i knew you were going to flame like you just did below. oh well, i guess you cant avoid the inevitable.

Show 5 quoted lines

> > - pc-windows
> > - pc-win
> > - win
>
> I find all of those horrible.

they arent great, but "win32" simply isnt valid. as soon as we started compiling for 64-bit and using 64-bit APIs it didnt make sense to keep using it. if you want to refer to all versions of the Microsoft OS you say "Windows", not "Windows XP", as that would be confusing for people using Windows 10. In the same vein you shouldnt refer to the current Windows API as "Win32" because its no longer just 32-bit.

Show 5 quoted lines

> ... except if you take into account that this has been our convention for,
> what, almost 9 years (since 44626dc7d5 (MSVC: Windows-native
> implementation for subset of Pthreads API, 2010-01-15), to be precise)? In
> that case, it makes a ton of sense, and one might be tempted to ask who
> the person wanting to change that thinks they are...

"That's the way it's always been done" is not a good reason to keep doing something. I would say the justification goes the other way, as to why we should keep using an old moniker when its past making sense.

> You may disagree all you want, but given that Torsten has been a lot more
> active on this code than you have been so far, I'll go with Torsten's
> taste. Which incidentally happens to match my tastes, so that's an added
> bonus.

in the end i dont really care what your taste is, or Torsten for that matter. I care that the issue be fixed.