Re: [PATCH v4] commit: add a commit.allowEmpty config variable

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 15, 2018, 08:40 UTC
Message-ID: <nycvar.QRO.7.76.6.1811150938070.41@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqzhucpa37.fsf@gitster-ct.c.googlers.com>

Hi,

On Wed, 14 Nov 2018, Junio C Hamano wrote:

Show 10 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> 
> > Agreed. I'm happy to see the test for-loop gone as I noted in
> > https://public-inbox.org/git/87d0rm7zeo.fsf@evledraar.gmail.com/ but as
> > noted in that v3 feedback the whole "why would anyone want this?"
> > explanation is still missing, and this still smells like a workaround
> > for a bug we should be fixing elsewhere in the sequencing code.
> 
> Thanks.  I share the same impression that this is sweeping a bug
> under a wrong rug.

I asked for clarification at https://github.com/git-for-windows/git/issues/1854 and in my best imitation of Lt Tawney Madison, I report back:

From @chucklu:

Show 17 quoted lines

> my user case is like this :
>
> When I want to cherr-pick commits from A to G (ABCDEFG), image C and E
> are merge commits.  Then I will get lots of popup like:
>
>    The previous cherry-pick is now empty, possibly due to conflict
>    resolution.
>    If you wish to commit it anyway, use:
>
>        git commit --allow-empty
>
>    If you wish to skip this commit, use:
>
>        git reset
>
>    Then "git cherry-pick --continue" will resume cherry-picking
>    the remaining commits.

My quick interpretation of this is that the user actually needs a way to skip silently commits which are now empty.

Ciao, Dscho