Re: [PATCH v4] commit: add a commit.allowEmpty config variable

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 14, 2018, 14:04 UTC
Message-ID: <nycvar.QRO.7.76.6.1811141456590.39@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqzhucpa37.fsf@gitster-ct.c.googlers.com>

Hi,

On Wed, 14 Nov 2018, Junio C Hamano wrote:

Show 10 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> 
> > Agreed. I'm happy to see the test for-loop gone as I noted in
> > https://public-inbox.org/git/87d0rm7zeo.fsf@evledraar.gmail.com/ but as
> > noted in that v3 feedback the whole "why would anyone want this?"
> > explanation is still missing, and this still smells like a workaround
> > for a bug we should be fixing elsewhere in the sequencing code.
> 
> Thanks.  I share the same impression that this is sweeping a bug
> under a wrong rug.

I agree that the scenario is under-explained. Of course, I have to say that this is not Tanushree's problem; They only copied what is in https://github.com/git-for-windows/git/issues/1854 and @chucklu did not grace us with an explanation, either.

Based on historical context, I would wager a bet that the scenario is that some commits that may or may not have been in a different SCM originally and that may or may not have been empty and/or squashed in `master` need to be cherry-picked.

But I agree that this should be clarified. I prodded the original wish-haver.

Ciao, Dscho