Re: [PATCH v4] commit: add a commit.allowEmpty config variable

From: Jeff King <peff@peff.net>
Date: Nov 15, 2018, 09:41 UTC
Message-ID: <20181115094101.GA15279@sigill.intra.peff.net>
In-Reply-To: <nycvar.QRO.7.76.6.1811150938070.41@tvgsbejvaqbjf.bet>

On Thu, Nov 15, 2018 at 09:40:38AM +0100, Johannes Schindelin wrote:

Show 22 quoted lines

> From @chucklu:
> 
> > my user case is like this :
> >
> > When I want to cherr-pick commits from A to G (ABCDEFG), image C and E
> > are merge commits.  Then I will get lots of popup like:
> >
> >    The previous cherry-pick is now empty, possibly due to conflict
> >    resolution.
> >    If you wish to commit it anyway, use:
> >
> >        git commit --allow-empty
> >
> >    If you wish to skip this commit, use:
> >
> >        git reset
> >
> >    Then "git cherry-pick --continue" will resume cherry-picking
> >    the remaining commits.
> 
> My quick interpretation of this is that the user actually needs a way to
> skip silently commits which are now empty.

If it's always intended to be used with cherry-pick, shouldn't cherry-pick learn a --keep-empty (like rebase has)? That would avoid even stopping for this case in the first place.

-Peff