Re: [PATCH v2 01/36] t/helper: add an empty test-tool program
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 27, 2018, 13:57 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1803271556170.77@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
- In-Reply-To
- <CAM0VKjmCKmQisLZcBw7ZROQmg3bVTXTOK6auo6DjjkOfKdPv1w@mail.gmail.com>
Hi Gábor,
On Tue, 27 Mar 2018, SZEDER Gábor wrote:
Show 18 quoted lines
> On Tue, Mar 27, 2018 at 12:14 AM, Johannes Schindelin > <Johannes.Schindelin@gmx.de> wrote: > > However, it seems that something is off, as > > ba5bec9589e9eefe2446044657963e25b7c8d88e is reported as fine on Windows: > > https://travis-ci.org/git/git/jobs/358260023 (while there is clearly a red > > X next to that commit in > > https://github.com/git/git/commits/ba5bec9589e9eefe2446044657963e25b7c8d88e, > > that X is due to a hiccup on macOS). > > > > It seems that the good-trees feature for Travis does not quite work as > > intended. Gábor? > > AFAICT it works as expected. > > When a build job encounters a commit with a tree that has previously > been built and tested successfully, then first it says so, like this: > > https://travis-ci.org/szeder/git/jobs/347295038#L635
But what if it has not been built successfully (as was the case here)? This very commit that is "succeeding" on Travis fails to compile on Windows.
Show 12 quoted lines
> and then skips the rest of the build job (see the 'exit 0' a few lines > later). > > In case of this Windows build job we haven't seen this tree yet: > > https://travis-ci.org/git/git/jobs/358260023#L467 > > so the build job continues as usual (see the 'test -z Windows' two lines > later). > > Unfortunately, I have no idea about how the rest of the Windows build > job is supposed to work...
Maybe Travis timed out waiting for the result, and marked it as a success?
Ciao, Dscho