Re: [PATCH v2 01/36] t/helper: add an empty test-tool program
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 26, 2018, 22:14 UTC
- Message-ID
- <nycvar.QRO.7.76.6.1803270007550.77@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
- In-Reply-To
- <CACsJy8Dz87YHiA48m_X7OmJXioKorUDNSyPy250jaqU7xt1JXQ@mail.gmail.com>
Hi Duy,
On Mon, 26 Mar 2018, Duy Nguyen wrote:
Show 26 quoted lines
> On Mon, Mar 26, 2018 at 5:27 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> >
> > On Sat, 24 Mar 2018, Nguyễn Thái Ngọc Duy wrote:
> >
> >> diff --git a/t/helper/test-tool.c b/t/helper/test-tool.c
> >> new file mode 100644
> >> index 0000000000..c730f718ca
> >> --- /dev/null
> >> +++ b/t/helper/test-tool.c
> >> @@ -0,0 +1,27 @@
> >> +#include "git-compat-util.h"
> >> +#include "test-tool.h"
> >> +
> >> +struct test_cmd {
> >> + const char *name;
> >> + int (*main)(int argc, const char **argv);
> >
> > This makes the build fail on Windows, as we override `main` in
> > compat/mingw.h:
>
> Sigh.. not complaining, but I wish somebody tries to compile git with
> wine (and automate it in travis). This way we could at least cover the
> compilation part for all major platforms. Probably too small for a
> GSoC (and making the test suite pass with wine may be too large for
> GSoC)We do have Continuous Testing of maint, master, next & pu.
However, it seems that something is off, as ba5bec9589e9eefe2446044657963e25b7c8d88e is reported as fine on Windows: https://travis-ci.org/git/git/jobs/358260023 (while there is clearly a red X next to that commit in https://github.com/git/git/commits/ba5bec9589e9eefe2446044657963e25b7c8d88e, that X is due to a hiccup on macOS).
It seems that the good-trees feature for Travis does not quite work as intended. Gábor?
Ciao, Dscho