Re: git-config: replaces ~/.gitconfig symlink with real file
- From
- Fredrik Tolf <fredrik@dolda2000.com>
- Date
- Jul 17, 2007, 20:35 UTC
- Message-ID
- <m3wswyojj2.fsf@pc7.dolda2000.com>
- In-Reply-To
- <Pine.LNX.4.64.0707170834040.14781@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> Hi, > > On Mon, 16 Jul 2007, Bradford Smith wrote: > >> So, I guess I need to add a GIT_CONFIG_HOME environment variable. If I >> get that done, I'll send a patch to the list including doc updates. > > Alternatively, you could actually not ignore my hint at readlink(2) and > have a proper fix, instead of playing games with environment variables.
Wouldn't it be nicer to avoid a lot of the complexity in checking symlinks, environment variables and what not, and just overwrite the file in place (with open(..., O_TRUNC | O_CREAT))? Does it happen terribly often that git-config crashes in the middle and leaves the file broken?
Fredrik Tolf