git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fully resolve symlinks when creating lockfiles

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 26, 2007, 18:35 UTC
Message-ID
<Pine.LNX.4.64.0707261934080.14781@racer.site>
In-Reply-To
<11854712542350-git-send-email-bradford.carl.smith@gmail.com>
Hi,
On Thu, 26 Jul 2007, Bradford C. Smith wrote:
Show 5 quoted lines
> Make the code for resolving symlinks in lockfile.c more robust as
> follows:
> 
> 1. Handle relative symlinks
> 2. recursively resolve symlink chains up to OS limit

FWIW I like what it does, but how. What is so wrong with just relying on is_absolute_path() and make_absolute_path()? The code would be much shorter then, and we need those functions anyway, methinks.

Ciao, Dscho

Previous: Bradford C. SmithNext: Morten Welinder
Message 12 of 21 in “git-config: replaces ~/.gitconfig symlink with real file”
  1. Bradford SmithJul 15, 2007
  2. Johannes SchindelinJul 15, 2007
  3. Nikolai WeibullJul 16, 2007
  4. Bradford SmithJul 16, 2007
  5. Bradford SmithJul 16, 2007
  6. Junio C HamanoJul 16, 2007
  7. 0/2 git-config should not replace symlinkBradford C. Smith, Jul 25, 2007
  8. 1/2 resolve symlinks when creating lockfilesBradford C. Smith, Jul 25, 2007
  9. 2/2 use lockfile.c routines in git_commit_set_multivar()Bradford C. Smith, Jul 25, 2007
  10. Junio C HamanoJul 25, 2007
  11. fully resolve symlinks when creating lockfilesBradford C. Smith, Jul 26, 2007
  12. Johannes SchindelinJul 26, 2007
  13. Morten WelinderJul 26, 2007
  14. Bradford SmithJul 27, 2007
  15. Junio C HamanoJul 27, 2007
  16. Johannes SchindelinJul 17, 2007
  17. Matthieu MoyJul 17, 2007
  18. Fredrik TolfJul 17, 2007
  19. Johannes SchindelinJul 17, 2007
  20. Catalin MarinasJul 17, 2007
  21. Johannes SchindelinJul 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.