git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-config: replaces ~/.gitconfig symlink with real file

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 17, 2007, 20:48 UTC
Message-ID
<Pine.LNX.4.64.0707172145590.14781@racer.site>
In-Reply-To
<m3wswyojj2.fsf@pc7.dolda2000.com>
Hi,
On Tue, 17 Jul 2007, Fredrik Tolf wrote:
Show 15 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 16 Jul 2007, Bradford Smith wrote:
> >
> >> So, I guess I need to add a GIT_CONFIG_HOME environment variable.  If I 
> >> get that done, I'll send a patch to the list including doc updates.
> >
> > Alternatively, you could actually not ignore my hint at readlink(2) and 
> > have a proper fix, instead of playing games with environment variables.
> 
> Wouldn't it be nicer to avoid a lot of the complexity in checking 
> symlinks, environment variables and what not, and just overwrite the 
> file in place (with open(..., O_TRUNC | O_CREAT))? Does it happen 
> terribly often that git-config crashes in the middle and leaves the file 
> broken?
No, it does not.  But when it does, I am not only annoyed.  I am PISSED!

The way we do it is the only safe way to do it, and I gladly spend some extra cycles for that. Too often, a small hard disk glitch (or just an empty laptop battery!) took some important data into the void. Too often, I _cursed_ at the machine, even if it was the programmers' fault.

Ciao, Dscho

Previous: Fredrik TolfNext: Catalin Marinas
Message 19 of 21 in “git-config: replaces ~/.gitconfig symlink with real file”
  1. Bradford SmithJul 15, 2007
  2. Johannes SchindelinJul 15, 2007
  3. Nikolai WeibullJul 16, 2007
  4. Bradford SmithJul 16, 2007
  5. Bradford SmithJul 16, 2007
  6. Junio C HamanoJul 16, 2007
  7. 0/2 git-config should not replace symlinkBradford C. Smith, Jul 25, 2007
  8. 1/2 resolve symlinks when creating lockfilesBradford C. Smith, Jul 25, 2007
  9. 2/2 use lockfile.c routines in git_commit_set_multivar()Bradford C. Smith, Jul 25, 2007
  10. Junio C HamanoJul 25, 2007
  11. fully resolve symlinks when creating lockfilesBradford C. Smith, Jul 26, 2007
  12. Johannes SchindelinJul 26, 2007
  13. Morten WelinderJul 26, 2007
  14. Bradford SmithJul 27, 2007
  15. Junio C HamanoJul 27, 2007
  16. Johannes SchindelinJul 17, 2007
  17. Matthieu MoyJul 17, 2007
  18. Fredrik TolfJul 17, 2007
  19. Johannes SchindelinJul 17, 2007
  20. Catalin MarinasJul 17, 2007
  21. Johannes SchindelinJul 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.