Re: [PATCH] Two RPM building improvements

From: Jakub Narebski <jnareb@gmail.com>
Date: Mar 27, 2009, 13:50 UTC
Message-ID: <m3k56b2hy2.fsf@localhost.localdomain>
In-Reply-To: <1238157134-27558-1-git-send-email-Niels@Basjes.nl>

Niels Basjes <Niels@Basjes.nl> writes:

> Two RPM building improvements:

Two _unrelated_ RPM building improvements squashed in one commit.

>   - Building the RPMs can now be done by a non-root user.

It was always possible, you only have to configure rpm / rpmbuild, namely put path to where you want your RPM_BUILDING directory in ~/.rpmmacros as %_topdir, for example:

  $ cat ~/.rpmmacros
  %_topdir        /home/local/builddir

Please RTFM first, before going to solve non-problem in (ugh) fairly complicated way.

>   - The additional target all-rpms now builds the RPMs for a multitude of target platforms.

Please wrap commit messages at 72-76 columns, at most at 80 columns. No such overly long lines, please.

But the all-rpms target looks like a good idea

-- 
Jakub Narebski
Poland
ShadeHawk on #git