Re: [PATCH] Two RPM building improvements

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 27, 2009, 14:45 UTC
Message-ID: <49CCE681.5050503@drmicha.warpmail.net>
In-Reply-To: <m3k56b2hy2.fsf@localhost.localdomain>

Jakub Narebski venit, vidit, dixit 27.03.2009 14:50:

Show 17 quoted lines

> Niels Basjes <Niels@Basjes.nl> writes:
> 
>> Two RPM building improvements:
> 
> Two _unrelated_ RPM building improvements squashed in one commit.
> 
>>   - Building the RPMs can now be done by a non-root user.
> 
> It was always possible, you only have to configure rpm / rpmbuild,
> namely put path to where you want your RPM_BUILDING directory in
> ~/.rpmmacros as %_topdir, for example:
> 
>   $ cat ~/.rpmmacros
>   %_topdir        /home/local/builddir
> 
> Please RTFM first, before going to solve non-problem in (ugh) fairly
> complicated way.

Also, the "solution" from the patch overrides any user choice from .rpmmacros, AFAICS.

Show 8 quoted lines

> 
>>   - The additional target all-rpms now builds the RPMs for a multitude of target platforms.
> 
> Please wrap commit messages at 72-76 columns, at most at 80 columns.
> No such overly long lines, please.
> 
> But the all-rpms target looks like a good idea
>