Re: [PATCH] Two RPM building improvements

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 27, 2009, 16:20 UTC
Message-ID: <7vvdpvdjj4.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <m3k56b2hy2.fsf@localhost.localdomain>

Jakub Narebski <jnareb@gmail.com> writes:

Show 17 quoted lines

> Niels Basjes <Niels@Basjes.nl> writes:
>
>> Two RPM building improvements:
>
> Two _unrelated_ RPM building improvements squashed in one commit.
>
>>   - Building the RPMs can now be done by a non-root user.
>
> It was always possible, you only have to configure rpm / rpmbuild,
> namely put path to where you want your RPM_BUILDING directory in
> ~/.rpmmacros as %_topdir, for example:
>
>   $ cat ~/.rpmmacros
>   %_topdir        /home/local/builddir
>
> Please RTFM first, before going to solve non-problem in (ugh) fairly
> complicated way.

That might be a bit too harsh to somebody who genuinely wished to share his improvement with others.

Being RPM novice, the first thing I asked around immediately after taking the maintainership over was the ~/.rpmmacros trick. We really should mention it in _our_ documentation, even just a sentence or two would be sufficient.