git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gitweb: standarize HTTP status codes

From
Jakub Narebski <jnareb@gmail.com>
Date
Jun 19, 2008, 22:37 UTC
Message-ID
<m3hcbpm4pe.fsf@localhost.localdomain>
In-Reply-To
<1213907110-5080-1-git-send-email-LeWiemann@gmail.com>
Lea Wiemann <lewiemann@gmail.com> writes:
> Changes since v2: die_error now adds the reason strings defined by RFC
> 2616 to the HTTP status code; incorporated Jakub's other suggestions.
> Diff to v2 follows.

This address both of my concerns: first, that for someone examining Mechanize-based gitweb test number like 403, or 500 would be magical number without explanation (reason phrase) other than 'Error'.

Second, that for casual / accidental gitweb developer who has to add
or modify a bit of code with die_error(...) wouldn't know which of
"magic number" to use, if the case didn't fail into described
situation.  Now it is enough to example die_error(...) in addition to
similar code...
 
> I didn't use the HTTP_NOT_FOUND etc. suggestion because I found it too
> verbose and obtrusive.
I can agree with that.
> Just a friendly reminder, please remember that discussing fairly
> trivial changes in-depth might be not a good use of all participants'
> time [...]
Well, this was what I though was patch revies... :-/
> Anyways, I hope everyone is happy with this version of the patch.
FWIW:
Acked-by: Jakub Narebski <jnareb@gmail.com>
-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Lea WiemannNext: Junio C Hamano
Message 23 of 25 in “gitweb: return correct HTTP status codes”
  1. gitweb: return correct HTTP status codesLea Wiemann, Jun 15, 2008
  2. Jakub NarebskiJun 15, 2008
  3. Lea WiemannJun 16, 2008
  4. Jakub NarebskiJun 16, 2008
  5. Lea WiemannJun 16, 2008
  6. Jakub NarebskiJun 16, 2008
  7. Lea WiemannJun 17, 2008
  8. Junio C HamanoJun 16, 2008
  9. Lea WiemannJun 17, 2008
  10. Jakub NarebskiJun 17, 2008
  11. Lea WiemannJun 17, 2008
  12. Jakub NarebskiJun 17, 2008
  13. Lea WiemannJun 17, 2008
  14. Jakub NarebskiJun 18, 2008
  15. Lea WiemannJun 18, 2008
  16. Jakub NarebskiJun 18, 2008
  17. Jakub NarebskiJun 16, 2008
  18. gitweb: standarize HTTP status codesLea Wiemann, Jun 18, 2008
  19. Jakub NarebskiJun 19, 2008
  20. Lea WiemannJun 19, 2008
  21. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  22. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  23. Jakub NarebskiJun 19, 2008
  24. Junio C HamanoJun 20, 2008
  25. Jakub NarebskiJun 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.