git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: return correct HTTP status codes

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 17, 2008, 22:28 UTC
Message-ID
<48583A73.7020508@gmail.com>
In-Reply-To
<200806171633.26864.jnareb@gmail.com>
Jakub Narebski wrote:
> But that means checking arguments in the "fast path", which means
> additional calls to git commands in the _common_ case, not only in
> the case of errors.

No, it doesn't, it just pipes stuff into cat-file --batch-check, which has to be opened on virtually any call to gitweb. Before telling me about the performance of my code, can you please (a) read it and (b) benchmark it? We lose a lot of time on pointless discussion otherwise.

> I'll try to come with example implementation using Error.pm and Git.pm

I don't think it's worth the time; I think I understand your point without an example implementation. :)

Unrelatedly, I thought we had agreement not to use Error.pm as of <http://thread.gmane.org/gmane.comp.version-control.git/83267/focus=83348> (though Git.pm still does use Error.pm, so it can still be used as long as there's no patch that removes all instances of it). I got *really* weird unreproduceable errors when throwing exceptions with Error.pm in gitweb, and I suspect that Error.pm (perhaps in interaction with some other module) was to blame. Just a warning. ;-)

-- Lea
Previous: Jakub NarebskiNext: Jakub Narebski
Message 11 of 25 in “gitweb: return correct HTTP status codes”
  1. gitweb: return correct HTTP status codesLea Wiemann, Jun 15, 2008
  2. Jakub NarebskiJun 15, 2008
  3. Lea WiemannJun 16, 2008
  4. Jakub NarebskiJun 16, 2008
  5. Lea WiemannJun 16, 2008
  6. Jakub NarebskiJun 16, 2008
  7. Lea WiemannJun 17, 2008
  8. Junio C HamanoJun 16, 2008
  9. Lea WiemannJun 17, 2008
  10. Jakub NarebskiJun 17, 2008
  11. Lea WiemannJun 17, 2008
  12. Jakub NarebskiJun 17, 2008
  13. Lea WiemannJun 17, 2008
  14. Jakub NarebskiJun 18, 2008
  15. Lea WiemannJun 18, 2008
  16. Jakub NarebskiJun 18, 2008
  17. Jakub NarebskiJun 16, 2008
  18. gitweb: standarize HTTP status codesLea Wiemann, Jun 18, 2008
  19. Jakub NarebskiJun 19, 2008
  20. Lea WiemannJun 19, 2008
  21. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  22. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  23. Jakub NarebskiJun 19, 2008
  24. Junio C HamanoJun 20, 2008
  25. Jakub NarebskiJun 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.