git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: return correct HTTP status codes

From
LWLea Wiemann <lewiemann@gmail.com>
Date
Jun 16, 2008, 21:49 UTC
Message-ID
<4856DFE8.9010809@gmail.com>
In-Reply-To
<200806161843.09372.jnareb@gmail.com>
Jakub Narebski wrote:
> Well, we could, perhaps, examine stderr (or redirect it to stdout and
> examine upon error) to check what was the error.

We don't have to -- gitweb's current (suboptimal) error checking is because it doesn't interface with git very well. The API I'm writing will fix this (i.e. provide proper feedback in all cases) so we'll have more specific status codes. IOW, we'll be able to differentiate between 500 and 404. Trust me on this one. ;-)

> But I think in all, or almost all cases, the source is wrong parameters
> in URL.  Now, returning 5xx _server_ error would make me want to email
> webmaster about error on his/her server, while 4xx _user_ error would
> make me examine my input

Since the status codes will get better (more accurate) anyway, I care more about correctness than practicalities right now (and I'm convinced that only 500 is correct in the cases we're talking about). That said, if you really want 404s in there, go ahead and send a follow-up patch, I won't object.

> BTW. I got three copies of this email: was it you fighting VGER
> anti-spam filter?

Yup. Apparently it simply greps for Content-TypXe: text/hXtml. *shakes head* :-)

-- Lea
Previous: Jakub NarebskiNext: Jakub Narebski
Message 5 of 25 in “gitweb: return correct HTTP status codes”
  1. gitweb: return correct HTTP status codesLea Wiemann, Jun 15, 2008
  2. Jakub NarebskiJun 15, 2008
  3. Lea WiemannJun 16, 2008
  4. Jakub NarebskiJun 16, 2008
  5. Lea WiemannJun 16, 2008
  6. Jakub NarebskiJun 16, 2008
  7. Lea WiemannJun 17, 2008
  8. Junio C HamanoJun 16, 2008
  9. Lea WiemannJun 17, 2008
  10. Jakub NarebskiJun 17, 2008
  11. Lea WiemannJun 17, 2008
  12. Jakub NarebskiJun 17, 2008
  13. Lea WiemannJun 17, 2008
  14. Jakub NarebskiJun 18, 2008
  15. Lea WiemannJun 18, 2008
  16. Jakub NarebskiJun 18, 2008
  17. Jakub NarebskiJun 16, 2008
  18. gitweb: standarize HTTP status codesLea Wiemann, Jun 18, 2008
  19. Jakub NarebskiJun 19, 2008
  20. Lea WiemannJun 19, 2008
  21. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  22. gitweb: standarize HTTP status codesLea Wiemann, Jun 19, 2008
  23. Jakub NarebskiJun 19, 2008
  24. Junio C HamanoJun 20, 2008
  25. Jakub NarebskiJun 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.