git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Configure test for FREAD_READS_DIRECTORIES

From
Jakub Narebski <jnareb@gmail.com>
Date
Mar 4, 2008, 12:17 UTC
Message-ID
<m3fxv6isxw.fsf@localhost.localdomain>
In-Reply-To
<200803041248.54197.michal.rokos@nextsoft.cz>
Michal Rokos <michal.rokos@nextsoft.cz> writes:
 
> I don't know how many people care about configure script since
> there are missing bits in it again and again. I believe it could
> receive good amount of testing only when it's merged in.

Because configure script is optional, people do tend to forget to add test to it, when adding new compile configuration option. Configuration is mainly done by guessing based on uname.

Unfortunately we don't have maintainer for configure script, who would catch new make configuration options, and add appropriate tests to ./configure.

> I'm trying to make GIT working on HPUX - next patch in my queue is
> about broken vsnprintf() that returns -1 on maxsize overrun. Do you
> think that it's more likely that patch will be accepted when I omit
> "broken vsnprintf()" detection code from configure.ac?

I think it would be better to split patch into two: one adding build option, or setting it for given operating system or operating system version, and one adding test to ./configure script. It is much simplier to test first patch; the patch to configure needs more review, as it should work correctly on all operating systems.

-- 
Jakub Narebski
Poland
ShadeHawk on #git
Previous: Michal RokosNext: Junio C Hamano
Message 6 of 7 in “Configure test for FREAD_READS_DIRECTORIES”
  1. Configure test for FREAD_READS_DIRECTORIESMichal Rokos, Mar 4, 2008
  2. Junio C HamanoMar 4, 2008
  3. Michal RokosMar 4, 2008
  4. Junio C HamanoMar 4, 2008
  5. Michal RokosMar 4, 2008
  6. Jakub NarebskiMar 4, 2008
  7. Junio C HamanoMar 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.