Re: [PATCH] Configure test for FREAD_READS_DIRECTORIES
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 5, 2008, 17:57 UTC
- Message-ID
- <7vd4q9njel.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <200803041248.54197.michal.rokos@nextsoft.cz>
Michal Rokos <michal.rokos@nextsoft.cz> writes:
> Will do... Did that. > > Do you think that there's some reason not-to merge it?
Yes, if you meant "apply as-is" by "merge it". No, if you meant "apply after an initial round of sanity checks, even if it is not perfect".
I was hoping that with this approach, in a week after you sent out your call-for-help-in-testing, you could send a version for inclusion with a commit log message that says "tested on X (by Foo), Y (by Bar),...", with the patch text that is exactly the same as what people tested. The point is not to make that list of platforms exhaustive, but at least make it a bit more than "works for me".
And I think that plan has worked well.