Re: 1.7.9, libcharset missing from EXTLIBS

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 10, 2012, 13:15 UTC
Message-ID: <m37gzuvni4.fsf@localhost.localdomain>
In-Reply-To: <CACBZZX45=mr=FMqFF+Pw4KPaDAtvs-ePLbFATpyFA93vSfZatw@mail.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> 2012/2/10 Junio C Hamano <gitster@pobox.com>:
>> Дилян Палаузов  <dilyan.palauzov@aegee.org> writes:

Show 13 quoted lines

>>> git 1.7.9 makes use of libcharset and /Makefile contains:
> >>
>>> ifdef HAVE_LIBCHARSET_H
>>>         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
>>> endif
>>> ...
>>> and the problem is, that libcharset is not used when linking.  To
>>> solve this, please replace the above extract from /Makefile with
>>>
>>> ifdef HAVE_LIBCHARSET_H
>>>         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
>>>         EXTLIBS += -lcharset
>>> endif

[....]

Show 9 quoted lines

> I've had some similar (privately sent) bug reports about the i18n
> stuff from someone who built his own Linux distro.
> 
> Basically we make assumptions that certain stuff will be in the C
> library on certain platforms, certain headers go with certain
> libraries etc.
> 
> Evidently none of this can really be relied upon and we'd have to
> probe for each one if we wanted to make it reliable.

Well, there is always *optional* configure.ac to do detection; "make configure; ./configure <options>" will generate config.mak.autogen with appropriate options -- we can add autodetection if -lcharset must be added.

-- 
Jakub Narębski