Re: 1.7.9, libcharset missing from EXTLIBS

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2012, 02:13 UTC
Message-ID: <7v1uq3toyq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F3472F4.4060605@aegee.org>

Дилян Палаузов  <dilyan.palauzov@aegee.org> writes:

Show 15 quoted lines

> Hello,
>
> git 1.7.9 makes use of libcharset and /Makefile contains:
>
> ifdef HAVE_LIBCHARSET_H
>         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
> endif
> ...
> and the problem is, that libcharset is not used when linking.  To
> solve this, please replace the above extract from /Makefile with
>
> ifdef HAVE_LIBCHARSET_H
>         BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
> 	EXTLIBS += -lcharset
> endif

Thanks.

What platform is this? Is there a guarantee that any and all system that use "#include <libcharset.h>" has to link with "-lcharset"?

What I am wondering is there are systems that need to include the header, but locale_charset() does not live in /lib/libcharset.a, in which case we cannot make HAVE_LIBCHARSET_H imply use of -lcharset.