Re: 1.7.9, libcharset missing from EXTLIBS
- From
- Дилян Палаузов <dilyan.palauzov@aegee.org>
- Date
- Feb 10, 2012, 10:21 UTC
- Message-ID
- <4F34EF9D.8030509@aegee.org>
- In-Reply-To
- <CACBZZX45=mr=FMqFF+Pw4KPaDAtvs-ePLbFATpyFA93vSfZatw@mail.gmail.com>
Hello,
Show 5 quoted lines
>> What platform is this? Is there a guarantee that any and all system that >> use "#include<libcharset.h>" has to link with "-lcharset"? > > I've had some similar (privately sent) bug reports about the i18n > stuff from someone who built his own Linux distro.
I run Linux from scratch.
>> What I am wondering is there are systems that need to include the header, >> but locale_charset() does not live in /lib/libcharset.a, in which case we >> cannot make HAVE_LIBCHARSET_H imply use of -lcharset.
I do not understand this. If you want to use a function from libcharset, you have to use both #include <libcharset.h> and -lcharset.
Със здраве Дилян
On 10.02.2012 11:06, Ævar Arnfjörð Bjarmason wrote:
Show 37 quoted lines
> 2012/2/10 Junio C Hamano<gitster@pobox.com>: >> Дилян Палаузов<dilyan.palauzov@aegee.org> writes: >> >>> Hello, >>> >>> git 1.7.9 makes use of libcharset and /Makefile contains: >>> >>> ifdef HAVE_LIBCHARSET_H >>> BASIC_CFLAGS += -DHAVE_LIBCHARSET_H >>> endif >>> ... >>> and the problem is, that libcharset is not used when linking. To >>> solve this, please replace the above extract from /Makefile with >>> >>> ifdef HAVE_LIBCHARSET_H >>> BASIC_CFLAGS += -DHAVE_LIBCHARSET_H >>> EXTLIBS += -lcharset >>> endif >> >> Thanks. >> >> What platform is this? Is there a guarantee that any and all system that >> use "#include<libcharset.h>" has to link with "-lcharset"? >> >> What I am wondering is there are systems that need to include the header, >> but locale_charset() does not live in /lib/libcharset.a, in which case we >> cannot make HAVE_LIBCHARSET_H imply use of -lcharset. > > I've had some similar (privately sent) bug reports about the i18n > stuff from someone who built his own Linux distro. > > Basically we make assumptions that certain stuff will be in the C > library on certain platforms, certain headers go with certain > libraries etc. > > Evidently none of this can really be relied upon and we'd have to > probe for each one if we wanted to make it reliable.
begin:vcard fn;quoted-printable:=D0=94=D0=B8=D0=BB=D1=8F=D0=BD =D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE= =D0=B2 n;quoted-printable;quoted-printable:=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2;=D0=94=D0=B8=D0=BB=D1=8F=D0=BD email;internet:dilyan.palauzov@aegee.org tel;home:+49-721-94193270 tel;cell:+49-162-4091172 note:sip:8372@aegee.org version:2.1 end:vcard