Re: [PATCH v2 5/8] t/README: Document test_external*

From: Jakub Narebski <jnareb@gmail.com>
Date: Jul 1, 2010, 20:52 UTC
Message-ID: <m3630zncwx.fsf@localhost.localdomain>
In-Reply-To: <1278015478-6920-6-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 9 quoted lines

> + - test_external [<prereq>] <message> <external> <script>
> +
> +   Execute a <script> with an <external> interpreter (like perl). This
> +   was added for tests like t9700-perl-git.sh which do most of their
> +   work in an external test script.
> +
> +	test_external_without_stderr \
> +	    'Perl API' \
> +	    "$PERL_PATH" "$TEST_DIRECTORY"/t9700/test.pl

I think this example was to be about 'test_external'; currently it duplicates example for 'test_external_without_stderr'.

Perhaps:

  +     test_external \
  +         'GitwebCache::*FileCache*' \
  +         "$PERL_PATH" "$TEST_DIRECTORY"/t9503/test_cache_interface.pl

Show 8 quoted lines

> + - test_external_without_stderr [<prereq>] <message> <external> <script>
> +
> +   Like test_external but fail if there's any output on stderr,
> +   instead of checking the exit code.
> +
> +	test_external_without_stderr \
> +	    'Perl API' \
> +	    "$PERL_PATH" "$TEST_DIRECTORY"/t9700/test.pl

-- 
Jakub Narebski
Poland
ShadeHawk on #git