git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/8] Improvements for t/README

From
Jeff King <peff@peff.net>
Date
Jul 2, 2010, 07:28 UTC
Message-ID
<20100702072803.GB1812@sigill.intra.peff.net>
In-Reply-To
<1278015478-6920-1-git-send-email-avarab@gmail.com>
On Thu, Jul 01, 2010 at 08:17:50PM +0000, Ævar Arnfjörð Bjarmason wrote:
Show 9 quoted lines
> This is v2 of the t/README series. It should address the concerns
> Junio and Jeff had about it.
> 
> Jeff:
> 
>   - Keep the ./ way of running tests, but elaborate a bit in the
>     commit message
> 
>   - Mention --root's effects on the trash directory location

Thanks. On the first point, I agree with Junio that dropping patch 1 is probably the best thing. For the second, your changes to patch 2 look good to me.

The rest look OK from my cursory read. I like the "do's and don'ts" list, which is a good way of communicating the little bits of wisdom (btw, I saw your post a few weeks ago about shell portability in git, and I think a list of known-bad constructs would be a good idea. Making a list from our previous fixes is on my todo list, but I haven't actually started on it. :) ).

One nit:
> +   You can gleam some further possible issues from the TAP grammar
> +   (see http://search.cpan.org/perldoc?TAP::Parser::Grammar#TAP_Grammar)
> +   but the best indication is to just run the tests with prove(1),
> +   it'll complain if anything is amiss.
I think you mean "glean".
-Peff
Previous: Ævar Arnfjörð Bjarmason
Message 14 of 14 in “Improvements for t/README”
  1. 0/8 Improvements for t/READMEÆvar Arnfjörð Bjarmason, Jul 1, 2010
  2. 1/8 t/README: Tests are all +x, ./test, not sh ./testÆvar Arnfjörð Bjarmason, Jul 1, 2010
  3. Junio C HamanoJul 1, 2010
  4. Ævar Arnfjörð BjarmasonJul 2, 2010
  5. 2/8 t/README: The trash is in 't/trash directory.$name'Ævar Arnfjörð Bjarmason, Jul 1, 2010
  6. 3/8 t/README: Typo: paralell -> parallelÆvar Arnfjörð Bjarmason, Jul 1, 2010
  7. 4/8 t/README: Document the prereq functions, and 3-arg test_*Ævar Arnfjörð Bjarmason, Jul 1, 2010
  8. 5/8 t/README: Document test_external*Ævar Arnfjörð Bjarmason, Jul 1, 2010
  9. Jakub NarebskiJul 1, 2010
  10. 5/8 t/README: Document test_external*Ævar Arnfjörð Bjarmason, Jul 1, 2010
  11. 6/8 t/README: Document test_expect_codeÆvar Arnfjörð Bjarmason, Jul 1, 2010
  12. 7/8 t/README: Add a section about skipping testsÆvar Arnfjörð Bjarmason, Jul 1, 2010
  13. 8/8 t/README: Document the do's and don'ts of testsÆvar Arnfjörð Bjarmason, Jul 1, 2010
  14. Jeff KingJul 2, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.