Re: [PATCH v2 1/8] t/README: Tests are all +x, ./test, not sh ./test

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2010, 23:54 UTC
Message-ID: <7v7hle3gih.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1278015478-6920-2-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> test-lib.sh runs tests with $SHELL_PATH or the #!/bin/sh shebang when
> run under prove. It's simpler to just show ./ as an example.

I don't think this is a good change at all. If we spell "sh" out, people with defective shell as the default shell on their system at least would know that they need to substitute that with "ksh" or "bash" or whatever.

Show 25 quoted lines

> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/README |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/t/README b/t/README
> index aa4ed28..b378ab1 100644
> --- a/t/README
> +++ b/t/README
> @@ -52,7 +52,7 @@ prove and other harnesses come with a lot of useful options. The
>  
>  You can also run each test individually from command line, like this:
>  
> -    $ sh ./t3010-ls-files-killed-modified.sh
> +    $ ./t3010-ls-files-killed-modified.sh
>      ok 1 - git update-index --add to add various paths.
>      ok 2 - git ls-files -k to show killed files.
>      ok 3 - validate git ls-files -k output.
> -- 
> 1.7.1.251.g92a7
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html