Re: git-svn failure when symlink added in svn

From: Seth Falcon <sethfalcon@gmail.com>
Date: Apr 28, 2007, 21:15 UTC
Message-ID: <m2k5vwfbf6.fsf@ziti.fhcrc.org>
In-Reply-To: <7v7irwjql6.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> writes:

Show 24 quoted lines

> Seth Falcon <sethfalcon@gmail.com> writes:
>
>> On OS X, I get:
>>
>>     ziti:~/temp seth$ ./perltest1.pl 
>>     read[5]: link 
>>     child says: child: at 5
>
> Ah, so the previous read($fh, $buf, 5) lets stdio absorb the
> whole (short) input, and the underlying seek pointer is not
> adjusted back across fork, and the child does not have anything
> to read.
>
>> And uncommenting the sysseek call, I get:
>>
>>     ziti:~/temp seth$ ./perltest1.pl 
>>     read[5]: link 
>>     child says: child: at 5
>>     child says: >>12345
>
> Then I suspect the following could be less invasive and more
> efficient fix for the problem.  I do not have an access to MacOS
> box, and I do not have a working sync with any SVN repository,
> so I cannot test it myself, though...

This also works as a fix for me on OS X and obviously is nicer than resorting to temp files. Again, with this patch against git master the test case that Eric posted passes as does one of my own examples.

+ seth