Re: git-svn failure when symlink added in svn

From: Eric Wong <normalperson@yhbt.net>
Date: Apr 29, 2007, 22:21 UTC
Message-ID: <20070429222136.GA1800@untitled>
In-Reply-To: <7vr6q2dhex.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 12 quoted lines

> diff --git a/git-svn.perl b/git-svn.perl
> index 4be8576..cef6697 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2464,15 +2464,15 @@ sub close_file {
>  	my $hash;
>  	my $path = $self->git_path($fb->{path});
>  	if (my $fh = $fb->{fh}) {
> -		seek($fh, 0, 0) or croak $!;
> +		sysseek($fh, 0, 0) or croak $!;
>  		my $md5 = Digest::MD5->new;
>  		$md5->addfile($fh);

We may want to keep the plain seek() here and do both seek and sysseek, I'm not sure if $md5->addfile() uses read or sysread internally.

-- 
Eric Wong