Re: git-svn failure when symlink added in svn

From: Alexander Klink <ak-git@cynops.de>
Date: Apr 30, 2007, 00:24 UTC
Message-ID: <20070430.d5c3a79fadd867d739e056ce9bc80eea@cynops.de>
In-Reply-To: <20070429222136.GA1800@untitled>

Hi,

On Sun, Apr 29, 2007 at 03:21:36PM -0700, Eric Wong wrote:

Show 9 quoted lines

> >  	my $path = $self->git_path($fb->{path});
> >  	if (my $fh = $fb->{fh}) {
> > -		seek($fh, 0, 0) or croak $!;
> > +		sysseek($fh, 0, 0) or croak $!;
> >  		my $md5 = Digest::MD5->new;
> >  		$md5->addfile($fh);
> 
> We may want to keep the plain seek() here and do both seek and sysseek,
> I'm not sure if $md5->addfile() uses read or sysread internally.

I've just had a quick look: it uses read.
Junio: I'll test the patch tomorrow or the day after tommorow and
let you know whether it works for me. Thanks for the quick fix(es) ...

Best regards,
    Alex

-- 
Dipl.-Math. Alexander Klink | IT-Security Engineer |    a.klink@cynops.de
 mobile: +49 (0)178 2121703 |          Cynops GmbH | http://www.cynops.de
----------------------------+----------------------+---------------------
      HRB 7833, Amtsgericht | USt-Id: DE 213094986 |     Geschäftsführer:
     Bad Homburg v. d. Höhe |                      |      Martin Bartosch