Re: [PATCH] rev-list: add "--full-objects" flag.
- From
Eric W. Biederman <ebiederm@xmission.com>
- Date
- Jul 12, 2005, 03:39 UTC
- Message-ID
- <m1wtnw66cc.fsf@ebiederm.dsl.xmission.com>
- In-Reply-To
- <Pine.LNX.4.58.0507112018560.17536@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 14 quoted lines
> On Mon, 11 Jul 2005, Eric W. Biederman wrote: >> >> The question: >> Does git-upload-pack which gets it's list of objects >> with "git-rev-list --objects needed1 needed2 needed3 ^has1 ^has2 ^has3" >> get any history beyond the top of tree of each branch. >> >> As I read the code it does not. > > It does. It gets all the history necessary for each branch. git-rev-list > will walk the whole history until it hits commits that as been marked as > uninteresting (or the parents of commits that have been marked as > uninteresting), and those are the ones that the receiver already has, of > course.
Ok. So the intention is sane then.
Looking closer it appears that commit_list_insert is recursive and that is what I missed.
Show 6 quoted lines
> So after you get a pack, you have all the history for all the branches you > got. > > A branch you _didn't_ get, you don't get any history for, of course, but > that doesn't matter. You'll get that history if you ever pull the branch > later.
Right. Things work well if you have all of the history.
Eric