git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] silencing warnings with curl 8.14

From
Collin Funk <collin.funk1@gmail.com>
Date
Jun 4, 2025, 21:23 UTC
Message-ID
<m1ecvzb3qu.fsf@gmail.com>
In-Reply-To
<20250604205505.GA1510724@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> The new version of curl (which hit Debian unstable a few days ago)
> causes a bunch of compiler warnings because we are passing regular ints
> to curl_easy_setopt() instead of longs. Passing longs has always been
> what you're supposed to do, but the new version is better about
> generating warnings with gcc (I think the type-check has been there for
> a long time, but I gather it was broken and recently fixed).
>
> I split this into three patches since the solutions vary slightly (well,
> the last two are the same, but my pontificating on the solution varies).
>
>   [1/3]: curl: fix integer constant typechecks with curl_easy_setopt()
>   [2/3]: curl: fix integer variable typechecks with curl_easy_setopt()
>   [3/3]: curl: fix symbolic constant typechecks with curl_easy_setopt()

I saw some GitHub CI's fail yesterday due to this as well [1], but can't seem to find the exact error logs at the moment...

Anyways, I came to the same conclusion as your patches. So:
Reviewed-by: Collin Funk <collin.funk1@gmail.com>

Thanks, Collin

[1] https://github.com/git/git
Previous: Jeff KingNext: Ramsay Jones
Message 14 of 16 in “silencing warnings with curl 8.14”
  1. 0/3 silencing warnings with curl 8.14Jeff King, Jun 4, 2025
  2. 1/3 curl: fix integer constant typechecks with curl_easy_setopt()Jeff King, Jun 4, 2025
  3. Johannes SchindelinJun 5, 2025
  4. Junio C HamanoJun 5, 2025
  5. Jeff KingJun 5, 2025
  6. Jeff KingJun 5, 2025
  7. Junio C HamanoJun 5, 2025
  8. Jeff KingJun 5, 2025
  9. 2/3 curl: fix integer variable typechecks with curl_easy_setopt()Jeff King, Jun 4, 2025
  10. 3/3 curl: fix symbolic constant typechecks with curl_easy_setopt()Jeff King, Jun 4, 2025
  11. Junio C HamanoJun 4, 2025
  12. Daniel StenbergJun 5, 2025
  13. Jeff KingJun 5, 2025
  14. Collin FunkJun 4, 2025
  15. Ramsay JonesJun 4, 2025
  16. Patrick SteinhardtJun 5, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.