Re: [PATCH 3/3] curl: fix symbolic constant typechecks with curl_easy_setopt()
- From
Jeff King <peff@peff.net>
- Date
- Jun 5, 2025, 07:25 UTC
- Message-ID
- <20250605072504.GB2066712@coredump.intra.peff.net>
- In-Reply-To
- <r1197994-o3so-6453-q16n-6n3on33n4nrp@unkk.fr>
On Thu, Jun 05, 2025 at 08:13:09AM +0200, Daniel Stenberg wrote:
Show 7 quoted lines
> On Wed, 4 Jun 2025, Jeff King wrote: > > > It seems kind of weird to me that curl doesn't define these constants as > > longs, since the point of them is to pass to curl_easy_setopt(). > > Agreed. Mostly just because of my lack of imagination when I added them a > long time ago.
Oh, OK. :)
Show 7 quoted lines
> We have over recent times updated several public option related defines to > better help applications to get int vs long right, but I have clearly missed > to do that for this particular set. > > I intend to fix this omission, but since you want to support building with > lots of old curl versions as well, this correction probably won't help you > for another decade or so... :-)
Sounds like a good plan. But yeah, we'll want to continue with the casts here for a while.
-Peff