Re: [PATCH 1/3] curl: fix integer constant typechecks with curl_easy_setopt()

From: Jeff King <peff@peff.net>
Date: Jun 5, 2025, 22:49 UTC
Message-ID: <20250605224910.GB3005733@coredump.intra.peff.net>
In-Reply-To: <xmqqh60u9nuo.fsf@gitster.g>

On Thu, Jun 05, 2025 at 09:04:15AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> --- >8 ---
> From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Date: Thu, 5 Jun 2025 12:57:35 +0200
> Subject: [PATCH] curl: pass `long` values where expected
> 
> A set of patches posted by Jeff King earlier covered some fallouts
> coming from new typecheck warnings cURL 8.14.0.  Here are to fix
> some more instances of the same new compile errors observed in the
> `osx-gcc` job of Git's CI builds.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Thanks, this patch looks good, and I think applying on top is a bit less work. I don't mind integrating them appropriately and re-rolling if we prefer a slightly cleaner history, though. (I don't think there's much value in recording which hit macOS and which did not).

-Peff