Re: [PATCH 2/3] Fixes bug: git-svn: svn.pathnameencoding is not respected with dcommit/set-tree

From: Alexey Shumkin <zapped@mail.ru>
Date: Feb 3, 2011, 20:28 UTC
Message-ID: <loom.20110203T212349-287@post.gmane.org>
In-Reply-To: <20110104232029.GA15889@dcvr.yhbt.net>

Eric Wong <normalperson <at> yhbt.net> writes:

> 
> Thomas Rast <trast <at> student.ethz.ch> wrote:
> > Zapped wrote:
> > > git-svn dcommit/set-tree fails when svn.pathnameencoding is set for native

OS encoding (e.g. cp1251

Show 12 quoted lines

> for Windows) though git-svn fetch/clone works well
> > 
> > I'll let Eric judge whether loading the encoding here is the right
> > fix, but here too the commit message states only what is broken, not
> > why you fixed it that way.  Can you elaborate a bit?
> > 
> > Also, this should be easy to cover with a test case, can you make one?
> 
> I second Thomas's requests.  I'm also a bit disappointed the original
> option is missing tests, especially since not many people are likely to
> use it.
>

Yes, I remember that, sorry, but I just have no enough time to get into git tests and make my own ones.