Re: [PATCH 1/3] Fixes bug: git-diff: class methods are not detected in hunk headers for Pascal

From: Thomas Rast <trast@student.ethz.ch>
Date: Jan 5, 2011, 14:31 UTC
Message-ID: <201101051531.49142.trast@student.ethz.ch>
In-Reply-To: <201101051523.55749.trast@student.ethz.ch>

Thomas Rast wrote:

Show 8 quoted lines

> Алексей Шумкин wrote:
> > I did as you said I changed commit message (also included
> > "Acked-by:"). So should I re-submit patch to the maillist as a new one
> > or as an answer to this thread?
> 
> It doesn't matter that much; most people resend as a reply to some
> email in the thread.  Just don't distribute the reroll all across the
> thread :-)

BTW speaking of series (and sorry for not pointing this out earlier):

Since these patches are not related to each other at all, it's better if you treat them as separate, not as a series. Making a series is sort of an "all or nothing" hint, meaning that if something holds up one patch in the series, Junio will treat the whole series as stalled, etc.

So probably it's better if you resend the acked patch alone, to show that it can stand on its own. Then later repeat the same for the other two patches when you have them ready.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch