Re: [PATCH 2/3] Fixes bug: git-svn: svn.pathnameencoding is not respected with dcommit/set-tree

From: Eric Wong <normalperson@yhbt.net>
Date: Jan 4, 2011, 23:20 UTC
Message-ID: <20110104232029.GA15889@dcvr.yhbt.net>
In-Reply-To: <201101041818.09365.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> wrote:

Show 8 quoted lines

> Zapped wrote:
> > git-svn dcommit/set-tree fails when svn.pathnameencoding is set for native OS encoding (e.g. cp1251 for Windows) though git-svn fetch/clone works well
> 
> I'll let Eric judge whether loading the encoding here is the right
> fix, but here too the commit message states only what is broken, not
> why you fixed it that way.  Can you elaborate a bit?
> 
> Also, this should be easy to cover with a test case, can you make one?

I second Thomas's requests. I'm also a bit disappointed the original option is missing tests, especially since not many people are likely to use it.

-- 
Eric Wong

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.