git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use faster byte swapping when compiling with MSVC

From
LSLudvig Strigeus <ludde@spotify.com>
Date
Oct 20, 2009, 12:20 UTC
Message-ID
<loom.20091020T141138-782@post.gmane.org>
In-Reply-To
<hbi4mt$tjt$1@ger.gmane.org>
Sebastian Schuberth <sschuberth <at> gmail.com> writes:
Show 13 quoted lines
> 
> When compiling with MSVC on x86-compatible, use an intrinsic for byte swapping.
> In contrast to the GCC path, we do not prefer inline assembly here as it is not
> supported for the x64 platform.
> 
>  
> +#elif defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_X64))
> +
> +#include <stdlib.h>
> +
> +#define bswap32(x) _byteswap_ulong(x)
> +
> +#endif

unsigned long (as used by _byteswap_ulong) is 64 bits on x64, right? Then it doesn't make sense to use _byteswap_ulong to swap 32-bit quantities (assuming that's what bswap32 does) would it?

/Ludde
Previous: Junio C HamanoNext: Erik Faye-Lund
Message 6 of 7 in “Use faster byte swapping when compiling with MSVC”
  1. Use faster byte swapping when compiling with MSVCSebastian Schuberth, Oct 19, 2009
  2. Junio C HamanoOct 20, 2009
  3. Sebastian SchuberthOct 20, 2009
  4. Johannes SchindelinOct 20, 2009
  5. Junio C HamanoOct 20, 2009
  6. Ludvig StrigeusOct 20, 2009
  7. Erik Faye-LundOct 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.