git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use faster byte swapping when compiling with MSVC

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Oct 20, 2009, 08:56 UTC
Message-ID
<bdca99240910200156x48511478w9eaa2239eb8342b4@mail.gmail.com>
In-Reply-To
<7vzl7mr1f5.fsf@alter.siamese.dyndns.org>
On Tue, Oct 20, 2009 at 09:04, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
>> When compiling with MSVC on x86-compatible, use an intrinsic for byte swapping.
>> In contrast to the GCC path, we do not prefer inline assembly here as it is not
>> supported for the x64 platform.
>>
>> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
>
> Unlike the other one this is not Acked by Marius, Dscho, or J6t; should I
> pick this up myself, or should I wait to be fed by one of msysgit people?

Well, in fact I am one of the msysgit poeple, although I mostly worked on the installer until now. In general, I like my patches to be reviewed, but this one is rather uncritical, I guess. So it's up to you, Junio, I'm perfectly OK with waiting for an ACK.

-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Johannes Schindelin
Message 3 of 7 in “Use faster byte swapping when compiling with MSVC”
  1. Use faster byte swapping when compiling with MSVCSebastian Schuberth, Oct 19, 2009
  2. Junio C HamanoOct 20, 2009
  3. Sebastian SchuberthOct 20, 2009
  4. Johannes SchindelinOct 20, 2009
  5. Junio C HamanoOct 20, 2009
  6. Ludvig StrigeusOct 20, 2009
  7. Erik Faye-LundOct 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.