Re: [PATCH] Use faster byte swapping when compiling with MSVC

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2009, 16:55 UTC
Message-ID: <7v4opuovhu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0910201149020.4985@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 14 quoted lines

>> Well, in fact I am one of the msysgit poeple, although I mostly worked 
>> on the installer until now. In general, I like my patches to be 
>> reviewed, but this one is rather uncritical, I guess. So it's up to you, 
>> Junio, I'm perfectly OK with waiting for an ACK.
>
> Apart from the fact that I do not have MSVC (and I don't want it, either), 
> there is another strong reason why I think Sebastian does not need ACKs or 
> SOBs on MSVC patches: he has plenty of experience as a maintainer of a 
> rather big (commercial) software that has to compile on Windows, MacOSX 
> and several Unix-type OSes (and it is known that Sebastian is a Windows 
> guy).
>
> So I would trust Sebastian's patches (at least when it comes to MSVC) 
> without even reviewing them.

I very appreciate a strong Ack in a specific area like this. I do skim msysgit list from time to time, and in retrospect I realize I _could_ have recognized Sebastian's name but somehow it didn't click.

I guess I should apply both patches to 'master', then.  Thanks.