git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/4] quote: add quote_path() flag to ignore config

From
Justin Tobler <jltobler@gmail.com>
Date
Feb 4, 2025, 22:39 UTC
Message-ID
<ksta3edbxwkl62u36xif63q4ebux5hdaxkbme6v6li5v3sgndb@nuu5yyp5clbk>
In-Reply-To
<76390e3b-e749-4d28-98a5-05db7c5fbcd3@gmail.com>
On 25/02/02 10:52AM, Phillip Wood wrote:
Show 18 quoted lines
> Hi Justin
> 
> On 01/02/2025 20:16, Justin Tobler wrote:
> > The `quote_path()` function invokes `quote_c_style_counted()` to handle
> > quoting. This means the output `quote_path()` is ultimately affected by
> > `core.quotePath` configuration. In a subsequent commit, `quote_path()`
> > will be used in a scenario where the output should remain consistent
> > regardless of the current configuration.
> > 
> > Introduce the `QUOTE_PATH_IGNORE_CONFIG` flag for `quote_path()`which
> > when set instructs the underlying `quote_c_style_counted()` to also
> > ignore the `core.quotePath` configuration when executed.
> 
> I'm confused as to why this is necessary. All of our existing plumbing
> commands that print paths respect core.quotePath so why is rev-list
> different? The config setting only affects the representation used for bytes
> 0x80 and above, control characters, backslash and double-quote are always
> quoted.

You are correct that it isn't neccesary. From a previous discussion, I initally thought it would preferrable to have consistent output for this plumbing operation, but as you pointed out other plumbing commands respect core.quotePath. I'll drop these first two patches in the next version.

Thanks for the feedback! -Justin

Previous: Phillip WoodNext: Phillip Wood
Message 18 of 37 in “rev-list: print missing object type with --missing=print-type”
  1. rev-list: print missing object type with --missing=print-typeJustin Tobler, Jan 8, 2025
  2. Christian CouderJan 8, 2025
  3. Justin ToblerJan 8, 2025
  4. Junio C HamanoJan 8, 2025
  5. Justin ToblerJan 8, 2025
  6. Junio C HamanoJan 8, 2025
  7. Justin ToblerJan 8, 2025
  8. 0/2 rev-list: print additional missing object informationJustin Tobler, Jan 10, 2025
  9. 0/4 rev-list: print additional missing object informationJustin Tobler, Feb 1, 2025
  10. 1/4 quote: add c quote flag to ignore core.quotePathJustin Tobler, Feb 1, 2025
  11. Christian CouderFeb 3, 2025
  12. Junio C HamanoFeb 3, 2025
  13. Junio C HamanoFeb 3, 2025
  14. Junio C HamanoFeb 4, 2025
  15. Justin ToblerFeb 4, 2025
  16. 2/4 quote: add quote_path() flag to ignore configJustin Tobler, Feb 1, 2025
  17. Phillip WoodFeb 2, 2025
  18. Justin ToblerFeb 4, 2025
  19. Phillip WoodFeb 11, 2025
  20. Christian CouderFeb 3, 2025
  21. Junio C HamanoFeb 3, 2025
  22. 3/4 rev-list: add print-info action to print missing object pathJustin Tobler, Feb 1, 2025
  23. 4/4 rev-list: extend print-info to print missing object typeJustin Tobler, Feb 1, 2025
  24. Christian CouderFeb 3, 2025
  25. Justin ToblerFeb 4, 2025
  26. 0/2 rev-list: print additional missing object informationJustin Tobler, Feb 5, 2025
  27. 1/2 rev-list: add print-info action to print missing object pathJustin Tobler, Feb 5, 2025
  28. 2/2 rev-list: extend print-info to print missing object typeJustin Tobler, Feb 5, 2025
  29. Christian CouderFeb 5, 2025
  30. Justin ToblerFeb 5, 2025
  31. Junio C HamanoFeb 5, 2025
  32. Justin ToblerFeb 5, 2025
  33. Junio C HamanoFeb 5, 2025
  34. 1/2 rev-list: add --missing-info to print missing object pathJustin Tobler, Jan 10, 2025
  35. Christian CouderJan 10, 2025
  36. Junio C HamanoJan 10, 2025
  37. 2/2 rev-list: extend --missing-info to print missing object typeJustin Tobler, Jan 10, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.