Re: [PATCH v3 0/4] rev-list: print additional missing object information
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 3, 2025, 10:45 UTC
- Message-ID
- <CAP8UFD0vbv7tRP1cac-q-Qqk7wxo57oP3VLqj7Gn_kHi41y=hQ@mail.gmail.com>
- In-Reply-To
- <20250201201658.11562-1-jltobler@gmail.com>
On Sat, Feb 1, 2025 at 9:20 PM Justin Tobler <jltobler@gmail.com> wrote:
Show 16 quoted lines
> > Greetings, > > It is possible to configure git-rev-list(1) to print the OID of missing > objects by setting the `--missing=print` option. While it is useful > knowing about these objects, it would be nice to have even more context > about the objects that are missing. Luckily, from an object containing > the missing object, it is possible to infer additional information the > missing object. For example, if the tree containing a missing blob still > exists, the tree entry for the missing object should contain path and > type information. > > This series aims to provide git-rev-list(1) with a new `print-info` > missing action for the `--missing` option that, when set, behaves like > the existing `print` action but also prints other potentially > interesting information about the missing object.
I took a look and commented a bit on patches 1/4 and 2/4. Not sure my comments are worth a reroll on their own. The other patches look good to me.
Anyway I think you might want to address Phillip Wood's concerns too:
https://lore.kernel.org/git/76390e3b-e749-4d28-98a5-05db7c5fbcd3@gmail.com/
Thanks.