Re: [PATCH v4 5/5] setup.c: create `discovery.bare`

From: Glen Choo <chooglen@google.com>
Date: Jun 7, 2022, 21:37 UTC
Message-ID: <kl6lh74w6tot.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <29053d029f8ec61095a2ad557be38b1d485a158f.1654635432.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines

> diff --git a/Documentation/config/discovery.txt b/Documentation/config/discovery.txt
> new file mode 100644
> index 00000000000..fbe93597e7c
> --- /dev/null
> +++ b/Documentation/config/discovery.txt
> @@ -0,0 +1,19 @@
> +discovery.bare::
> +	'(Protected config only)' Specifies whether Git will work with a
> +	bare repository that it found during repository discovery. This
> +	has no effect if the repository is specified directly via the
> +	--git-dir command-line option or the GIT_DIR environment
> +	variable (see linkgit:git[1]).

Ugh, I forgot to update the docs for `discovery.bare`. This should be reworded to be consistent with `safe.directory` and `uploadpack.packObjectsHook`, e.g.

   discovery.bare::
   	Specifies whether Git will work with a bare repository that it found
   	during repository discovery. This has no effect if the repository is
   	specified directly via the --git-dir command-line option or the
   	GIT_DIR environment variable (see linkgit:git[1]).

    This config setting is only respected in protected configuration
    (see <<SCOPES>>). This prevents the untrusted repository from
    tampering with this value.