Re: [PATCH v4 0/5] config: introduce discovery.bare and protected config

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 22, 2022, 22:03 UTC
Message-ID: <20220622220331.3734584-1-jonathantanmy@google.com>
In-Reply-To: <pull.1261.v4.git.git.1654635432.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:

> Glen Choo (5):
>   Documentation/git-config.txt: add SCOPES section
>   Documentation: define protected configuration

Forgot to mention when I was sending my comments on patch 2: we should standardize on "protected config" and not use "protected configuration" anywhere.

>   config: read protected config with `git_protected_config()`
>   safe.directory: use git_protected_config()
>   setup.c: create `discovery.bare`

Thanks - I think this is a nice feature to have. Everything looks good except for some minor comments on text in patch 2, which I have sent.

One alternative design would have been to have separate configsets for protected config and non-protected config (or even better, separate configsets for trace2 config, protected config minus trace2 config, and non-protected config) but that doesn't have to block the submission of this patch set.